Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to CLA in README.md #481

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

ronnygunawan
Copy link

The link was broken because of an extra dot.

Copy link
Collaborator

@derrickstolee derrickstolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for noticing this!

@derrickstolee
Copy link
Collaborator

@ronnygunawan could you rebase this onto vfs-2.35.1? We had to update the branch due to Git for Windows 2.35.1.

To do this locally, you should be able to do something like the following (assuming your remote name for this fork is ms):

git fetch ms
git rebase --onto ms/vfs-2.35.1 ms/vfs-2.35.0 patch-1

Then force-push the branch to your fork and edit this PR to target vfs-2.35.1.

Sorry for the trouble! I've updated the default branch so this shouldn't happen again.

@ronnygunawan ronnygunawan changed the base branch from vfs-2.35.0 to vfs-2.35.1 February 3, 2022 08:49
@ronnygunawan
Copy link
Author

@derrickstolee I've rebased it onto vfs-2.35.1

Copy link
Collaborator

@derrickstolee derrickstolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the rebase! I'll merge this once the builds are green.

@derrickstolee
Copy link
Collaborator

Thanks for doing the rebase! I'll merge this once the builds are green.

The builds aren't going because you have a previous green build that is causing the build to skip. I'll merge with admin privileges.

Thanks again for your contribution!

@derrickstolee derrickstolee merged commit 2f6531a into microsoft:vfs-2.35.1 Feb 3, 2022
derrickstolee added a commit that referenced this pull request Jun 16, 2022
The link was broken because of an extra dot.
dscho pushed a commit that referenced this pull request Jun 17, 2022
The link was broken because of an extra dot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants